Skip to content

Add addTimeMarker to PointSeries chart config#10169

Merged
thomasneirynck merged 1 commit intoelastic:masterfrom
coverslide:current-time-marker-for-point-series-fix
Feb 21, 2017
Merged

Add addTimeMarker to PointSeries chart config#10169
thomasneirynck merged 1 commit intoelastic:masterfrom
coverslide:current-time-marker-for-point-series-fix

Conversation

@coverslide
Copy link
Copy Markdown
Contributor

@coverslide coverslide commented Feb 2, 2017 •
edited
Loading

Fixes #10143

Looks like we don't pass that config properly to the visualization

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 2, 2017

Can one of the admins verify this patch?

@coverslide
Copy link
Copy Markdown
Contributor Author

coverslide commented Feb 2, 2017

cc @bhavyarm

@epixa epixa added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review labels Feb 2, 2017
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Feb 2, 2017

jenkins, test this

@tbragin tbragin requested a review from ppisljar February 6, 2017 20:45
@ppisljar
Copy link
Copy Markdown
Contributor

ppisljar commented Feb 7, 2017

LGTM

@coverslide
Copy link
Copy Markdown
Contributor Author

coverslide commented Feb 19, 2017 •
edited
Loading

Is there a second we can add for this to get this merged? @epixa @thomasneirynck

@thomasneirynck thomasneirynck self-assigned this Feb 21, 2017
@thomasneirynck thomasneirynck merged commit a3ddaa1 into elastic:master Feb 21, 2017
@thomasneirynck
Copy link
Copy Markdown
Contributor

thomasneirynck commented Feb 21, 2017

thanks @coverslide!

elastic-jasper added a commit that referenced this pull request Feb 21, 2017
@elastic-jasper
Add addTimeMarker to PointSeries chart config
de2f2a1 
Backports PR #10169

**Commit 1:**
Add addTimeMarker to PointSeries chart config

* Original sha: dfaec9a
* Authored by Richard Hoffman <coverslide@gmail.com> on 2017-02-02T22:14:19Z
@elastic-jasper elastic-jasper mentioned this pull request Feb 21, 2017
Closed
thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Feb 21, 2017
@coverslide @thomasneirynck
Add addTimeMarker to PointSeries chart config (elastic#10169)
ddb8b60
thomasneirynck added a commit that referenced this pull request Feb 21, 2017
@thomasneirynck
Add addTimeMarker to PointSeries chart config (#10169) (#10488)
faea8c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppisljar ppisljar ppisljar approved these changes

+1 more reviewer

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thomasneirynck thomasneirynck

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.0 v6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@coverslide @elasticmachine @epixa @ppisljar @thomasneirynck